Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update neocmake extension to v0.0.5 #1257

Merged
merged 3 commits into from
Aug 20, 2024
Merged

Conversation

k0tran
Copy link
Contributor

@k0tran k0tran commented Aug 16, 2024

  • Fix lsp path for linux
  • Add aarch64 support for MacOS

Copy link

cla-bot bot commented Aug 16, 2024

We require contributors to sign our Contributor License Agreement, and we don't have @k0tran on file. You can sign our CLA at https://zed.dev/cla. Once you've signed, post a comment here that says '@cla-bot check'.

@k0tran
Copy link
Contributor Author

k0tran commented Aug 16, 2024

@cla-bot check

@cla-bot cla-bot bot added the cla-signed label Aug 16, 2024
Copy link

cla-bot bot commented Aug 16, 2024

The cla-bot has been summoned, and re-checked this pull request!

@maxdeviant
Copy link
Member

@k0tran It looks like in this version the code to remove older language servers was removed:

k0tran/zed_neocmake@7cab1dd...3763214#diff-7a58343a9453f7caca008e4a9375027a58151234c9537ed79f44078fcb824343L74-L81

Was there a particular reason for this?

@k0tran
Copy link
Contributor Author

k0tran commented Aug 19, 2024

Was there a particular reason for this?

When I first saw this code I thought it is for removing everything except lsp binary in the archive. And since neocmake-lsp is just a single binary - I removed it. If it's also removing old lsp versions then I can bring it back for that purpose

@maxdeviant
Copy link
Member

Was there a particular reason for this?

When I first saw this code I thought it is for removing everything except lsp binary in the archive. And since neocmake-lsp is just a single binary - I removed it. If it's also removing old lsp versions then I can bring it back for that purpose

Yea, that code is there for removing all but the current version of the language server, so that they don't accumulate and take up space.

@k0tran
Copy link
Contributor Author

k0tran commented Aug 19, 2024

@maxdeviant Updated extension, thanks for the feedback!

@k0tran k0tran changed the title Update neocmake extension to 0.0.4 Update neocmake extension to 0.0.5 Aug 20, 2024
@maxdeviant maxdeviant changed the title Update neocmake extension to 0.0.5 Update neocmake extension to v0.0.5 Aug 20, 2024
@maxdeviant maxdeviant merged commit 7b0887c into zed-industries:main Aug 20, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants