-
Notifications
You must be signed in to change notification settings - Fork 398
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update neocmake extension to v0.0.5 #1257
Conversation
k0tran
commented
Aug 16, 2024
- Fix lsp path for linux
- Add aarch64 support for MacOS
We require contributors to sign our Contributor License Agreement, and we don't have @k0tran on file. You can sign our CLA at https://zed.dev/cla. Once you've signed, post a comment here that says '@cla-bot check'. |
@cla-bot check |
The cla-bot has been summoned, and re-checked this pull request! |
@k0tran It looks like in this version the code to remove older language servers was removed: Was there a particular reason for this? |
When I first saw this code I thought it is for removing everything except lsp binary in the archive. And since neocmake-lsp is just a single binary - I removed it. If it's also removing old lsp versions then I can bring it back for that purpose |
Yea, that code is there for removing all but the current version of the language server, so that they don't accumulate and take up space. |
@maxdeviant Updated extension, thanks for the feedback! |