Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Vitesse theme to v0.0.2 #1299

Merged
merged 4 commits into from
Sep 16, 2024
Merged

Update Vitesse theme to v0.0.2 #1299

merged 4 commits into from
Sep 16, 2024

Conversation

musicq
Copy link
Contributor

@musicq musicq commented Aug 26, 2024

Makes hints more readable

Copy link

cla-bot bot commented Aug 26, 2024

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: kui.liang.
This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email [email protected]
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

This PR updates the jsonnet extension to the latest version v0.2.0
@cla-bot cla-bot bot added the cla-signed label Aug 26, 2024
@maxdeviant maxdeviant changed the title Update Vitesse theme to 0.0.2 Update Vitesse theme to v0.0.2 Aug 26, 2024
Copy link
Member

@maxdeviant maxdeviant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@musicq It looks like the Vitesse extension is still using the old extension.json format.

We'll need to update it to use extension.toml: https://zed.dev/docs/extensions/developing-extensions#directory-structure-of-a-zed-extension

Copy link
Member

@maxdeviant maxdeviant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like the extension ID changed from vitesse to vitesse-theme.

Could we change it back to vitesse?

Copy link

cla-bot bot commented Sep 16, 2024

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: kui.liang.
This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email [email protected]
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

@cla-bot cla-bot bot removed the cla-signed label Sep 16, 2024
@maxdeviant maxdeviant merged commit aa79e7c into zed-industries:main Sep 16, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants