Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Jinja2 extension #1320

Merged
merged 7 commits into from
Aug 30, 2024
Merged

Add Jinja2 extension #1320

merged 7 commits into from
Aug 30, 2024

Conversation

ArcherHume
Copy link
Contributor

Adds syntax highlighting and indentation to Jinja2 templates.

Extension repo: https://github.com/ArcherHume/jinja2-support

Copy link

cla-bot bot commented Aug 28, 2024

We require contributors to sign our Contributor License Agreement, and we don't have @ArcherHume on file. You can sign our CLA at https://zed.dev/cla. Once you've signed, post a comment here that says '@cla-bot check'.

@ArcherHume
Copy link
Contributor Author

@cla-bot check

@cla-bot cla-bot bot added the cla-signed label Aug 28, 2024
Copy link

cla-bot bot commented Aug 28, 2024

The cla-bot has been summoned, and re-checked this pull request!

@maxdeviant maxdeviant changed the title Added Jinja2 Support extension Add Jinja2 Support extension Aug 29, 2024
@maxdeviant maxdeviant changed the title Add Jinja2 Support extension Add Jinja2 extension Aug 29, 2024
Copy link
Member

@maxdeviant maxdeviant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

You'll need to remove the grammars directory from your extension repo and add it to .gitignore.

@ArcherHume
Copy link
Contributor Author

Thanks for the PR!

You'll need to remove the grammars directory from your extension repo and add it to .gitignore.

Apologies for that, was in a rush! Done now :)

Copy link
Member

@maxdeviant maxdeviant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@maxdeviant maxdeviant merged commit 52ddc15 into zed-industries:main Aug 30, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants