Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Sublime Mariana theme #1356

Merged

Conversation

hnatiukr
Copy link
Contributor

@hnatiukr hnatiukr commented Sep 3, 2024

Theme, that imitates Sublime Text 4's Mariana theme.

The Mariana color scheme is known for its cool, muted tones that provide a soothing yet vibrant coding environment, making it easy on the eyes during long coding sessions. This theme avoids the use of cursive or italic styles, ensuring a consistent and clean look across all text elements for enhanced readability and focus.

There are two distinct variations: Sublime Mariana and Sublime Breakers. Theme variation closely mirrors the original, offering a cool, muted color scheme that’s easy on the eyes.

mariana-zed

Note

I’m aware that a similar theme already exists, but this version offers some key differences. Notably, it contains only two color schemas and uses only the normal text style, with no italic or bold elements, to provide a clean and uniform appearance throughout. If you decide to decline this PR due to the similar existing theme, no problem—just wanted to share an alternative version!

Copy link

cla-bot bot commented Sep 3, 2024

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Roman Hnatiuk.
This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email [email protected]
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

@hnatiukr hnatiukr force-pushed the extension/theme/mariana-sublime branch from c0ea6a6 to 3ca3494 Compare September 3, 2024 21:56
Copy link

cla-bot bot commented Sep 3, 2024

We require contributors to sign our Contributor License Agreement, and we don't have @hnatiukr on file. You can sign our CLA at https://zed.dev/cla. Once you've signed, post a comment here that says '@cla-bot check'.

@hnatiukr
Copy link
Contributor Author

hnatiukr commented Sep 3, 2024

@cla-bot check

@cla-bot cla-bot bot added the cla-signed label Sep 3, 2024
Copy link

cla-bot bot commented Sep 3, 2024

The cla-bot has been summoned, and re-checked this pull request!

@jackTabsCode
Copy link
Contributor

I just tried it out, and this theme looks a lot more faithful to the colors of the original than the existing extension! Nice work

@maxdeviant
Copy link
Member

@blaqat I'd be curious to get your take here as the author of the existing Mariana theme.

I think there is room to have a theme that is true to the original Sublime one, if the divergence in your version of Mariana was an intentional one.

@blaqat
Copy link
Contributor

blaqat commented Sep 10, 2024

@blaqat I'd be curious to get your take here as the author of the existing Mariana theme.

This is perfect! I had made the 'Mariana Sublime' variant in mine specifically for people who were requesting more similarities to the original. This one is much better at doing that.

My original version was intentionally different / biased since it took elements I preferred from Mariana Pro and Juliana. I also wouldn't mind renaming mine to reduce confusion since it's more of a variation than faithful remake.

@maxdeviant
Copy link
Member

@blaqat I'd be curious to get your take here as the author of the existing Mariana theme.

This is perfect! I had made the 'Mariana Sublime' variant in mine specifically for people who were requesting more similarities to the original. This one is much better at doing that.

My original version was intentionally different / biased since it took elements I preferred from Mariana Pro and Juliana. I also wouldn't mind renaming mine to reduce confusion since it's more of a variation than faithful remake.

Awesome!

@maxdeviant maxdeviant merged commit 8be7bf6 into zed-industries:main Sep 10, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants