Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update kanagawa-themes to v0.1.1 #1440

Merged
merged 1 commit into from
Oct 1, 2024
Merged

Conversation

ethangilmore
Copy link
Contributor

@ethangilmore ethangilmore commented Sep 20, 2024

Update kanagawa-themes to v0.1.1

Adds three new themes and a no italics version

@cla-bot cla-bot bot added the cla-signed label Sep 20, 2024
Copy link
Member

@maxdeviant maxdeviant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ethangilmore Thanks!

It looks like this extension is still using the old extension.json format.

We'll need to update it to use extension.toml: https://zed.dev/docs/extensions/developing-extensions#directory-structure-of-a-zed-extension

Update kanagawa-theme to v0.1.1

Update kanaga-themes to v0.1.1
@ethangilmore
Copy link
Contributor Author

Hello, I believe I have made the necessary changes. Can you review this and let me know if I need to do anything more?

@maxdeviant maxdeviant closed this Oct 1, 2024
@maxdeviant maxdeviant reopened this Oct 1, 2024
Copy link
Member

@maxdeviant maxdeviant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello, I believe I have made the necessary changes. Can you review this and let me know if I need to do anything more?

Looks good, thanks!

@maxdeviant maxdeviant merged commit ef333f4 into zed-industries:main Oct 1, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants