-
Notifications
You must be signed in to change notification settings - Fork 3.5k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
gpui: Add
line_clamp
to truncate text after a specified number of l…
…ines (#23058) Release Notes: - N/A Add this feature for some case we need keep 2 or 3 lines, but truncate. For example the blog post summary. - Added `line_clamp` method. Ref: https://tailwindcss.com/docs/line-clamp ## Break changes: - Renamed `gpui::Truncate` to `gpui::TextOverflow` to match [CSS](https://developer.mozilla.org/en-US/docs/Web/CSS/text-overflow). - Update `truncate` style method to match [Tailwind CSS](https://tailwindcss.com/docs/text-overflow) behavior: ```css overflow: hidden; text-overflow: ellipsis; white-space: nowrap; ``` <img width="538" alt="image" src="https://github.com/user-attachments/assets/c69c4213-eac9-4087-9daa-ce7afe18c758" /> ## Show case <img width="816" alt="image" src="https://github.com/user-attachments/assets/e0660290-8042-4954-b93c-c729d609484a" /> ![CleanShot 2025-01-13 at 17 22 05](https://github.com/user-attachments/assets/38644892-79fe-4254-af9e-88c1349561bd) ## Describe changes The [second commit](6b41c27) for make sure text layout to match with the line clamp. Before this change, they may wrap many lines in sometimes. And I also make line_clamp default to 1 if we used `truncate` to ensure no wrap. > TODO: There is still a tiny detail that is not easy to fix. This problem only occurs in the case of certain long words. I will think about how to improve it later. At present, this has some flaws but does not affect the use.
- Loading branch information
Showing
14 changed files
with
117 additions
and
65 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.