626 paginate endless scrolling on saves #628
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for voluble-nougat-015dd1 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
- Works similarly to the one used in FindArticles, by updating the list with extra articles until we do not get anything from the API. - Each call takes about 1.4s - 1.6s in my development environment (to fetch 20 articles). Before, this user had about 76 articles taking 6.3s to fetch all.
tfnribeiro
force-pushed
the
626-paginate-endless-scrolling-on-saves
branch
from
c9b8881 to
25df96f
Compare
mircealungu
requested changes
Nov 18, 2024
src/articles/OwnArticles.js
Outdated
| setIsWaitingForNewArticles(false); | ||
| } | ||
|
|
||
| function handleScroll() { |
There was a problem hiding this comment.
there's a bit of duplication now between OwnArticles and FindArticles. I think we can live with it, but at the same time, if there was an easy way to extract a useArticlePagination hook from the two it might be good to do. But if it's too complicated, then it's fine.
There was a problem hiding this comment.
Indeed, I had thought about this - but I was a bit unsure about how to do it in a way that would allow for different behaviours depending on which component we are using the pagination from.
I have just pushed what I ended up coding - let me know what you think
- Renamed variables to match the name suggested by Mircea.
- Remove hardcoded setTitle
…tion. piece of cake :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires the PR in the API: zeeguu/api#292
Note: I removed the isMounted check as it is an anti-pattern (we want to see the warning in case it's an issue). We should try to follow a pattern similar to the one shown here: https://legacy.reactjs.org/blog/2015/12/16/ismounted-antipattern.html