Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

btest-bg-run-helper: Ignore SIGTERM to self during cleanup #105

Merged
merged 2 commits into from
Dec 4, 2024

Conversation

awelzel
Copy link
Contributor

@awelzel awelzel commented Oct 2, 2024

The kill 0 invocation would kill the btest-bg-run-helper itself, causing the subsequent logic to not be executed, resulting in runaway processes on the system.

@awelzel
Copy link
Contributor Author

awelzel commented Oct 2, 2024

I was tempted to add a -SIGKILL for the process group at the end of the cleanup, but IIUC in the worst case this may SIGKILL unrelated processes because btest-setsid ignores setsid() error situations.

@awelzel awelzel requested a review from rsmmr December 4, 2024 08:20
btest-bg-run-helper Outdated Show resolved Hide resolved
btest-bg-run-helper Outdated Show resolved Hide resolved
The kill 0 invocation would kill the btest-bg-run-helper itself,
causing the subsequent logic to not be executed, resulting in
runaway processes on the system.
@awelzel awelzel force-pushed the topic/awelzel/avoid-escaped-processes branch from 06ab036 to 44f19d8 Compare December 4, 2024 14:00
@awelzel awelzel force-pushed the topic/awelzel/avoid-escaped-processes branch from 44f19d8 to d3a3b05 Compare December 4, 2024 15:00
@awelzel awelzel requested a review from rsmmr December 4, 2024 15:00
btest-bg-run-helper Show resolved Hide resolved
@awelzel awelzel merged commit 11ed25a into master Dec 4, 2024
22 checks passed
@awelzel awelzel deleted the topic/awelzel/avoid-escaped-processes branch December 4, 2024 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants