Simplify generation of temporary files #99
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of manuall relying in `$$` being unique, with this patch we instead use `mktemp` which creates a unique, temporary file which we can use later. This also removes the possibility that we accidentially overwrite other existing files in the final location, e.g., from previous, failed runs. Via the default behavior of `mktemp` with this patch we also switch from forced generation of temporary files in `/tmp` to possibly `$TMPDIR` if set.
bbannier
force-pushed
the
topic/bbannier/use-mktemp
branch
from
f40cf0f to
22fbdf9
Compare
awelzel
reviewed
Oct 4, 2023
awelzel
approved these changes
Oct 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of manuall relying in
$$being unique, with this patch we instead usemktempwhich creates a unique, temporary file which we can use later. This also removes the possibility that we accidentially overwrite other existing files in the final location, e.g., from previous, failed runs.Via the default behavior of
mktempwith this patch we also switch from forced generation of temporary files in/tmpto possibly$TMPDIRif set.