Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid dereferencing cookie field that could intentionally be unset #64

Merged
merged 1 commit into from
Dec 12, 2023

Conversation

timwoj
Copy link
Member

@timwoj timwoj commented Dec 11, 2023

This field is marked &optional in the Zeek package and can intentionally be null. The field in ZeekQuery is already a std::optional so there's no need to dereference it here.

@timwoj timwoj merged commit 9eba4fb into main Dec 12, 2023
5 of 6 checks passed
@timwoj timwoj deleted the topic/timw/fix-cookie branch December 12, 2023 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants