-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restructure macOS app structure #65
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4dd7ece
to
3b844ba
Compare
fae1479
to
32daa45
Compare
32daa45
to
c3bd582
Compare
c3bd582
to
5be1193
Compare
5be1193
to
48930db
Compare
Broker support isn't needed anymore with Zeek >= 5.0. We now build without it by default. To re-enable Broker support for Zeek 4.x, you can still configure with ``--enable-broker``. The pre-build binaries also no longer include Broker support.
This will be used for tables relying on system services that need some time to initialize.
By default, our deployment target is now the current platform's major version. That avoids problems with system libraries not matching in for what they were built. To set a different deployment target, there's now a corresponding `configure` option. We set that for CI builds. As part of this change, we also raise the CI's deployment target to Ventura.
We now use Apple's new `notarytool` along with App Store Connect credentials. In additional to `main`, CI now runs notarization (but not publishing) on a new (protected) branch `topic/ci-release-test`. That can be used to test notarization from CI by pushing changes directly to that branch.
48930db
to
96019f8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This passes tests now, including full notarization on macOS. I'm planing to review the changes once more (some of them have been sitting in a branch for a while now) and then merge this into
main
.gawk
for auxin scripts.