Add remote console #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rsmmr
force-pushed
the
topic/robin/socket-comm
branch
2 times, most recently
from
c41e9f8 to
7e7f749
Compare
By default, an agent now creates a UNIX socket for its console that an external client can connect to. To connect to an already running agent, execute `zeek-agent -r` on the same machine (note that client and server must be running as the same user, probably `root`). Client and server can specify a different socket path through `-s <PATH>`. The environment variable `ZEEK_AGENT_SOCKET` can be set to specify the path as well. Remote consoles aren't support on Windows yet. Internally, we switch the classic local console over to the same IPC mechanism we now use for remote consoles, so that there's only one implementation. For Windows, where actual IPC isn't implemented yet, we provide a dummy implementation for this purpose that just forwards data inside the main (and only) process. Closes #8.
rsmmr
force-pushed
the
topic/robin/socket-comm
branch
from
1919428 to
f8a284d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: This has a known issue in Windows where the local console stops taking input after the first command. I leave that as a TODO for tracking down for now.