Add Dockerfile, read raw romfs with zstd+sarc+byml #10
Conversation
|
this effectively addresses #7 too, although I don't have the webp map tiles either |
Auto-decompress/conversion should be a fallback, not a requirement. It doesn't make sense to force everyone to install additional tools and to decompress/convert over and over again just because some people can't be bothered to decompress/convert once ahead of time :P |
build.ts
Outdated
| const zsDicPath = fs.mkdtempSync('zsdicpack'); | ||
| execSync(`zstd -d "${romfsPath}/Pack/ZsDic.pack.zs" -o "${zsDicPath}/ZsDic.pack"`); | ||
| execSync(`sarc x --directory "${zsDicPath}" "${zsDicPath}/ZsDic.pack"`); |
There was a problem hiding this comment.
I think these are the only potentially breaking calls for people who've already unpacked files. If we only do this when we need it, that should all be compatible, just give it a romfs-looking folder with the unpacked files.
I think that works for everyone? To be clear this PR already accepts unpacked files, it doesn't force you to re extract everything if you've already done it... unless you leave eg byml+yml files coexisting in the same folder, but we could reorder those ifs.
There was a problem hiding this comment.
right, this will still take your files if you make a folder containing:
/Banc: what you've been passing to-d/Ecosystem/FieldMapArea: what you've been passing to-b
I don't understand why people would want to extract into a structure that doesn't resemble the origin, since this loses context, but if this is still too much hassle then we can fix up the argument handling to take both ways. (done!)
There was a problem hiding this comment.
It's fine to require the folder structure to match the game's RomFS or extracted RomFS, so long as a full dump or compression is not required
|
aquacluck
force-pushed
the
misc-docker
branch
2 times, most recently
from
58e7109
to
31e3018
Compare
This changes how build.ts is called, and also fails if these tools aren't installed which might be a little controversial. Runtime is also increased since we'll decompress+decode on every re-import, but thankfully it doesn't seem too excessive to me.
Enables https://github.com/aquacluck/totk-objmap-docker