Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Script for moving decomp symbols to Ghidra #57

Merged
merged 8 commits into from
Nov 28, 2024

Conversation

robojumper
Copy link
Collaborator

@robojumper robojumper commented Oct 6, 2024

  • Remove spaces instead of replacing them with _
  • Ensure @GUARD@ and @LOCAL@ symbols remain visible
  • Look into Write section address / size to splits.txt encounter/decomp-toolkit#31 for better REL section identification (based on size, maybe) not needed
  • mHeap::~mHeap not transferred?
  • Keep a history of previous names in the comment
  • Templated functions include template return type in stripped name
  • create Ghidra functions at func addresses
  • Wait for cwdemangle update or port RootCubed's demangle script to Python 2.7

@robojumper robojumper marked this pull request as ready for review October 25, 2024 20:37
@elijah-thomas774
Copy link
Collaborator

elijah-thomas774 commented Nov 2, 2024

image
So far i love how its been working!

One small thing of which I don't really know how to use the script and see if I can change myself (where do I go for documentation?). It seems to create the labels properly, but the name for the function does not contain the namespace (sometimes).

I assume this is due to naming something that had to be marked as a function first.

@robojumper
Copy link
Collaborator Author

robojumper commented Nov 3, 2024

Hm the function name thing is probably NationalSecurityAgency/ghidra#6840, I ran into the problem that the function name was literally dAcDemoNpcBird_c::executeState_Fly1 without any namespacing, so I changed it to use just the last namespace component as the function name. I will look into a solution. The Ghidra people seem to be interested in addressing this problem though

On second thought, passing None as the function name might be the correct solution

@robojumper
Copy link
Collaborator Author

Should be better now

@robojumper robojumper merged commit 5dd7182 into zeldaret:main Nov 28, 2024
1 check passed
@robojumper robojumper deleted the map2ghidra branch November 28, 2024 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants