fix(break-pane): strip logical position when inserting pane to new tab (

#3973)
zellij-org · Feb 3, 2025 · 0b9e61c · 0b9e61c
1 parent a853a96
commit 0b9e61c
Showing 1 changed file with 7 additions and 2 deletions.
diff --git a/zellij-server/src/panes/tiled_panes/mod.rs b/zellij-server/src/panes/tiled_panes/mod.rs
@@ -216,8 +216,13 @@ impl TiledPanes {
             })
             .copied()
         {
-            if let Some(pane) = self.panes.remove(&pane_id) {
-                self.add_pane(pane.pid(), pane, true, None);
+            if let Some(mut pane) = self.panes.remove(&pane_id) {
+                // we must strip the logical position here because it's likely a straggler from
+                // this pane's previous tab and would cause chaos if considered in the new one
+                let mut pane_geom = pane.position_and_size();
+                pane_geom.logical_position = None;
+                pane.set_geom(pane_geom);
+                self.add_pane_with_existing_geom(pane.pid(), pane);
             }
         }
     }