-
-
Notifications
You must be signed in to change notification settings - Fork 693
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CWD, PID and TTY to PaneInfo to make it available to plugins #3800
base: main
Are you sure you want to change the base?
Conversation
I didn't know about #3765 before starting this. But I think this PR includes most of it, too. |
Hey @msirringhaus - thanks for putting this together and for your patience! First thing: while I realize we talked about this and can see the tremendous effort you put into the tty discovery, I would rather not go forward with that part. If this is the easiest way to get it (and we don't have a good way to get it on macos) then I'd rather shelf it for now and move forward with the other bits. Second: I think the cwd is a great addition but I'm wondering if perhaps we can be a little smarter about it. As opposed to the process id, the cwd is something that can change often and regardless of the Zellij state. Meaning that if I go into a terminal pane and do Do you think there's a way to somehow listen to these changes - hopefully asynchronously - and trigger an update (not necessarily a |
I'll try to think of something during the upcoming vacation period and hopefully find time to remove the TTY-part of this PR. |
ca33f39
to
92f6aa4
Compare
Rebased this PR on top of new master and removed the TTY-stuff. |
Hey, thanks for this! This looks good. Two last adjustments please:
|
Hey @msirringhaus - where do we stand with this? I want to release at least the basic features without updating the |
…ed for a potential current_cwd
92f6aa4
to
91e16a5
Compare
Right, sorry about that! Your two change requests should be implemented now |
Hm, the end to end test failure doesn't look like it has anything to do with my changes? |
Notes:
PaneManifest
directly from screen to the plugin, we proxy it throughPty
, which then fills out runtime-specific values (tests need to include this additional hop now, too)PathBufs
, so we have to convert them to Strings.