Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add speed limit attribute #699

Open
wants to merge 13 commits into
base: master
Choose a base branch
from

Conversation

ampersand38
Copy link
Member

@ampersand38 ampersand38 commented Jan 10, 2023

When merged this pull request will:

I messed up #648 and a new pr seemed like the easiest way to fix it.
Attribute toggle settings split to #716

@Kexanone Kexanone added the feature Adds a new feature label Jan 31, 2023
@ampersand38 ampersand38 changed the title Add settings to toggle attributes and speed limit attribute Add speed limit attribute Mar 16, 2023
@ampersand38 ampersand38 marked this pull request as draft March 16, 2023 19:26

if (_vehicle isEqualType []) exitWith {
{
[_x, _speed] call FUNC(setSpeed);
Copy link
Contributor

@rautamiekka rautamiekka Mar 18, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if spawn would speed things along ?

^ Granted, my laptop doesn't run both the game and the Server instance simultaneously especially fast, and on it I noticed that forEach+spawn takes a noticeable time to get things done compared to call, like CBA_fnc_setLoadout can take something like 400-600ms (looks like it) to get the squad equipped (which also happens in a random order) instead of next to instantly (in the squad leader's command bar order).

^ Might help when someone has a less good Internet connection, dunno.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh interesting, so each one can run "in parallel"?
As for network, I tried to structure the CBA event and the function such that the selected array is pre-filtered and then only sent on network once, if I'm getting your meaning correctly.

@ampersand38 ampersand38 marked this pull request as ready for review October 12, 2023 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Adds a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Limit vehicle speed module
3 participants