Improve attach objects module #752
Conversation
|
I think maybe this should be a separate keybind. I think it would be annoying to go through the dialog every time you want to attach an object. |
Can do. I'm leaning toward "Attach to Bone" since the description mentions "selected objects", which could get confused with "Attach to Selection". |
alt + shift is move very fast in zeus
|
And what do you think about attempting to translate from Czech names? https://community.bistudio.com/wiki/ArmA:_Armed_Assault:_Selection_Translations |
| } else { | ||
| [_x, _entity, _selection, _isRelative] call FUNC(attachToSelection); | ||
| }; | ||
| } forEach _objects params ["_selectionPos", "_selectionY", "_selectionZ"]; |
There was a problem hiding this comment.
Is this actually the intention ?
^ Since _objects will be iterated before params gets to it, and params returns bool based on the success of, or use of a default value in, the creation of the mentioned vars, so even putting it as forEach (...) would give an error, IIUC, and the mentioned vars are only used after the forEach.
There was a problem hiding this comment.
Ah, yeah you're right. forEach does return the last iteration, but it's not a good use for it, and it was in the wrong place relative to the if anyway.
|
I think the module can have the "full" attach to options. If it is doable, translating the names would be good, similarly to how hitpoint names are handled. |
When merged this pull request will:
Attach to selection in parent object
Maintain relative position
Maintain relative orientation or match selection orientation
Show hint on reference bone
https://www.youtube.com/watch?v=RjuEQJxmY-o