Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bulked up fixes to the release #249

Merged
merged 1 commit into from
May 24, 2023
Merged

Bulked up fixes to the release #249

merged 1 commit into from
May 24, 2023

Conversation

zenangst
Copy link
Owner

@zenangst zenangst commented May 24, 2023

The picking of configuration looks like this now:

Screenshot 2023-05-24 at 18 19 38
  • Fix cache identifiers
  • Expose run on CommandEngine
  • Move the keyboard engine error definitions outside of the class
  • Move the apple script plugin error definitions outside of the class
  • Set notification default to false on KeyboardCommand
  • Set defaults for ScriptCommand's
  • Set notification default to false on TypeCommand
  • Add editor command to the default configuration (either Xcode or TextEdit)
  • Add additional application commands (Terminal, Safari) to the default configuration
  • Add example Apple Script command to show how to use Apple Script to open a specific
    note in the Notes.app
  • Add additional open commands (Documents, Downloads)
  • Add rebinding commands to add Vim binding navigation
  • Add imdb.com url command
  • Add type command that is scoped to Mail to add a mail signature
  • Add support for running commands in the DetailCommandActionReducer
  • Implement basic error handling when running commands using the DetailCommandActionReducer
    by forwarding the errors to NSAlert
  • Add new UI for the "pick configuration" screen
  • Pass the same namespace between loading and pick-configuration view
    for a nice transition between states
  • Fix visual bugs and nit-picky design improvements in the content list
  • Fix bug with using .focusSection in the EditableKeyboardShortcutView
  • Remove redundant .onAppear implementation in the GroupsListView

Reference: #243

- Fix cache identifiers
- Expose `run` on `CommandEngine`
- Move the keyboard engine error definitions outside of the class
- Move the apple script plugin error definitions outside of the class
- Set notification default to false on `KeyboardCommand`
- Set defaults for `ScriptCommand`'s
- Set notification default to false on `TypeCommand`
- Add editor command to the default configuration (either Xcode or TextEdit)
- Add additional application commands (Terminal, Safari) to the default configuration
- Add example Apple Script command to show how to use Apple Script to open a specific
  note in the Notes.app
- Add additional open commands (Documents, Downloads)
- Add rebinding commands to add Vim binding navigation
- Add imdb.com url command
- Add type command that is scoped to Mail to add a mail signature
- Add support for running commands in the `DetailCommandActionReducer`
- Implement basic error handling when running commands using the `DetailCommandActionReducer`
  by forwarding the errors to `NSAlert`
- Add new UI for the "pick configuration" screen
- Pass the same namespace between loading and pick-configuration view
  for a nice transition between states
- Fix visual bugs and nit-picky design improvements in the content list
- Fix bug with using `.focusSection` in the `EditableKeyboardShortcutView`
- Remove redundant `.onAppear` implementation in the `GroupsListView`
@zenangst zenangst merged commit 98c4bd1 into main May 24, 2023
1 check passed
@zenangst zenangst deleted the fix/things-before-release branch May 24, 2023 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant