Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Bump v3.0.6 - Add Gemfile and Gemfile.lock for different Ruby versions" #570

Closed
wants to merge 1 commit into from

Conversation

JinHuangAtZen
Copy link
Contributor

Reverts #568

@JinHuangAtZen JinHuangAtZen requested a review from a team as a code owner May 20, 2024 23:26
Copy link
Contributor

@ecoologic ecoologic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we should revert versions that have already been made available to the public. We want all the 3.0.6 versions to be exactly the same code base.

It might be argued that this is only CI changes, so it was redundant to release a version in the first place, but what I would do at this point is just leave the main branch as is (closing this PR), and when we ship some value to the customers we can release a higher version.

Lastly, if we really wanted to undo a version release, we would have to delete the git tag and remove the version from rubygems, something I would do only if no-one ever downloaded the new version. -- Now I checked and noticed that we haven't even released 3.0.5 anyway in rubygems, so seems like the release process wasn't even followed to completion. 🤔 I don't think this changes my opinion about this PR. I suggest closing and moving on.

@JinHuangAtZen
Copy link
Contributor Author

I don't think we should revert versions that have already been made available to the public. We want all the 3.0.6 versions to be exactly the same code base.

It might be argued that this is only CI changes, so it was redundant to release a version in the first place, but what I would do at this point is just leave the main branch as is (closing this PR), and when we ship some value to the customers we can release a higher version.

Lastly, if we really wanted to undo a version release, we would have to delete the git tag and remove the version from rubygems, something I would do only if no-one ever downloaded the new version. -- Now I checked and noticed that we haven't even released 3.0.5 anyway in rubygems, so seems like the release process wasn't even followed to completion. 🤔 I don't think this changes my opinion about this PR. I suggest closing and moving on.

Yup, I didn't go ahead to release 3.0.5 because the issue we found, will close this PR for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants