[RED-2215] Fix/Improve Live Specs #573
Merged
+44
−55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fbvilela
force-pushed
the
fvilela/spec_tests
branch
4 times, most recently
from
0a13e99
to
8373b02
Compare
fbvilela
force-pushed
the
fvilela/spec_tests
branch
2 times, most recently
from
e21dbec
to
c4617a9
Compare
ecoologic
approved these changes
Jun 13, 2024
| c.allow_http_connections_when_no_cassette = @previous_allow_http_connections | ||
| end | ||
| end | ||
|
|
There was a problem hiding this comment.
I'm OK with this solution. 👍
| @@ -21,26 +21,26 @@ def it_should_be_creatable(options = {}) | |||
|
|
|||
| before(:all) do | |||
| VCR.use_cassette("#{described_class.to_s}_create") do | |||
| @object = described_class.create(client, valid_attributes.merge(default_options)) | |||
| @creatable_object = described_class.create!(client, valid_attributes.merge(default_options)) | |||
spec/macros/resource_macros.rb
Outdated
| @object.send("#{attribute}=", value) | ||
| extra.each { |k, v| @object.send("#{k}=", v) } | ||
| @updatable_object.send("#{attribute}=", value) | ||
| extra.each { |k, v| @updatable_object.send("#{k}=", v) } |
There was a problem hiding this comment.
Neat: would it be possible to use public_send instead?
spec/macros/resource_macros.rb
Outdated
| end | ||
|
|
||
| it "should be savable" do | ||
| expect(@object.save).to be(true) | ||
| expect(@updatable_object.save!).to be(true) |
There was a problem hiding this comment.
In this case I think it should be save without the bang.
You could try:
Suggested change
| expect(@updatable_object.save!).to be(true) | |
| expect(object.save).to be(true), "Expected object to save, but it failed with errors: #{object.errors.full_messages.join(', ')}" |
fbvilela
force-pushed
the
fvilela/spec_tests
branch
from
c4617a9
to
c002382
Compare
fbvilela
force-pushed
the
fvilela/spec_tests
branch
from
c002382
to
26f5277
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix and Improve the Live Specs