Skip to content

Commit

Permalink
* Avoid line continuation
Browse files Browse the repository at this point in the history
* Fix typo and rename the method to build_errors
  • Loading branch information
Rogers authored and Rogers committed May 19, 2023
1 parent 16dbf15 commit 7ad2d88
Showing 1 changed file with 5 additions and 7 deletions.
12 changes: 5 additions & 7 deletions lib/zendesk_apps_support/validations/requirements.rb
Original file line number Diff line number Diff line change
Expand Up @@ -9,22 +9,20 @@ module Requirements
class << self
def call(package)
unless package.has_requirements?
return [ValidationError.new(:missing_requirements)] \
if package.manifest.requirements_only?

return [ValidationError.new(:missing_requirements)] if package.manifest.requirements_only?

return []
end

return [ValidationError.new(:requirements_not_supported)] \
unless supports_requirements(package)
return [ValidationError.new(:requirements_not_supported)] unless supports_requirements(package)

begin
requirements = package.requirements_json
rescue ZendeskAppsSupport::Manifest::OverrideError => e
return [ValidationError.new(:duplicate_requirements, duplicate_keys: e.key, count: 1)]
end

erros(requirements)
build_errors(requirements)
rescue JSON::ParserError => e
return [ValidationError.new(:requirements_not_json, errors: e)]
end
Expand Down Expand Up @@ -175,7 +173,7 @@ def invalid_target_types(requirements)
end
end

def erros(requirements)
def build_errors(requirements)
[].tap do |errors|
errors << invalid_requirements_types(requirements)
errors << excessive_requirements(requirements)
Expand Down

0 comments on commit 7ad2d88

Please sign in to comment.