Skip to content

Commit

Permalink
style: rename rest parameter to other
Browse files Browse the repository at this point in the history
  • Loading branch information
ze-flo committed Oct 11, 2024
1 parent ddbbcba commit f62a443
Show file tree
Hide file tree
Showing 6 changed files with 13 additions and 13 deletions.
4 changes: 2 additions & 2 deletions packages/chrome/src/elements/header/Header.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,8 @@ import { HeaderItemText } from './HeaderItemText';
import { HeaderItemWrapper } from './HeaderItemWrapper';

export const HeaderComponent = React.forwardRef<HTMLElement, IHeaderProps>(
({ isStandalone, ...rest }, ref) => (
<StyledHeader ref={ref} $isStandalone={isStandalone} {...rest} />
({ isStandalone, ...other }, ref) => (
<StyledHeader ref={ref} $isStandalone={isStandalone} {...other} />
)
);

Expand Down
6 changes: 3 additions & 3 deletions packages/chrome/src/elements/header/HeaderItem.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ import { StyledHeaderItem, StyledLogoHeaderItem } from '../../styled';
* @extends ButtonHTMLAttributes<HTMLButtonElement>
*/
export const HeaderItem = React.forwardRef<HTMLButtonElement, IHeaderItemProps>(
({ hasLogo, isRound, maxX, maxY, product, ...rest }, ref) => {
({ hasLogo, isRound, maxX, maxY, product, ...other }, ref) => {
if (hasLogo) {
return (
<StyledLogoHeaderItem
Expand All @@ -25,12 +25,12 @@ export const HeaderItem = React.forwardRef<HTMLButtonElement, IHeaderItemProps>(
$maxX={maxX}
$maxY={maxY}
$product={product}
{...rest}
{...other}
/>
);
}

return <StyledHeaderItem ref={ref} $isRound={isRound} $maxX={maxX} $maxY={maxY} {...rest} />;
return <StyledHeaderItem ref={ref} $isRound={isRound} $maxX={maxX} $maxY={maxY} {...other} />;
}
);

Expand Down
4 changes: 2 additions & 2 deletions packages/chrome/src/elements/header/HeaderItemText.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,8 @@ import { StyledHeaderItemText } from '../../styled';
* @extends HTMLAttributes<HTMLSpanElement>
*/
export const HeaderItemText = React.forwardRef<HTMLElement, IHeaderItemTextProps>(
({ isClipped, ...rest }, ref) => (
<StyledHeaderItemText ref={ref} $isClipped={isClipped} {...rest} />
({ isClipped, ...other }, ref) => (
<StyledHeaderItemText ref={ref} $isClipped={isClipped} {...other} />
)
);

Expand Down
4 changes: 2 additions & 2 deletions packages/chrome/src/elements/nav/Nav.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ import { NavItemText } from './NavItemText';
import { NavList } from './NavList';

export const NavComponent = React.forwardRef<HTMLElement, INavProps>(
({ isExpanded, ...rest }, ref) => {
({ isExpanded, ...other }, ref) => {
const { hue, isLight } = useChromeContext();
const navContextValue = useMemo(() => ({ isExpanded: !!isExpanded }), [isExpanded]);

Expand All @@ -30,7 +30,7 @@ export const NavComponent = React.forwardRef<HTMLElement, INavProps>(
})}
>
<NavContext.Provider value={navContextValue}>
<StyledNav ref={ref} $isExpanded={isExpanded} $hue={hue} {...rest} />
<StyledNav ref={ref} $isExpanded={isExpanded} $hue={hue} {...other} />
</NavContext.Provider>
</ThemeProvider>
);
Expand Down
4 changes: 2 additions & 2 deletions packages/chrome/src/elements/nav/NavItemText.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -17,11 +17,11 @@ import { useNavContext } from '../../utils/useNavContext';
* @extends HTMLAttributes<HTMLSpanElement>
*/
export const NavItemText = React.forwardRef<HTMLElement, INavItemTextProps>(
({ isWrapped, ...rest }, ref) => {
({ isWrapped, ...other }, ref) => {
const { isExpanded } = useNavContext();

return (
<StyledNavItemText ref={ref} $isExpanded={isExpanded} $isWrapped={isWrapped} {...rest} />
<StyledNavItemText ref={ref} $isExpanded={isExpanded} $isWrapped={isWrapped} {...other} />
);
}
);
Expand Down
4 changes: 2 additions & 2 deletions packages/chrome/src/elements/sheet/components/Footer.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,8 @@ import React, { forwardRef } from 'react';
import { ISheetFooterProps } from '../../../types';
import { StyledSheetFooter } from '../../../styled';

const SheetFooter = forwardRef<HTMLElement, ISheetFooterProps>(({ isCompact, ...rest }, ref) => {
return <StyledSheetFooter ref={ref} $isCompact={isCompact} {...rest} />;
const SheetFooter = forwardRef<HTMLElement, ISheetFooterProps>(({ isCompact, ...other }, ref) => {
return <StyledSheetFooter ref={ref} $isCompact={isCompact} {...other} />;
});

SheetFooter.displayName = 'Sheet.Footer';
Expand Down

0 comments on commit f62a443

Please sign in to comment.