refactor(colorpickers, grid, loaders, notifications, tags, tooltips): use transient props + snapshot testing [DO NOT MERGE] #1967
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… ze-flo/transient-props-rest-w-stories-specs
|
Acknowledging these 2 commits. Both introduce welcomed fixes:
Other snapshot mismatches should be flagged as a possible regression. |
ze-flo
changed the title
ze-flo
force-pushed
the
ze-flo/transient-props-rest-w-stories-specs
branch
from
e94b189 to
c7ec75d
Compare
|
#1968 merged. Closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds snapshot tests from stories from the following packages:
buttonsformsdropdownsdrodowns.legacydraggablemodalstypographygridloaderscolorpickerstooltipstagsnotificationsThese tests capture the current visual appearance of the stories before making changes to transient props.
This helps ensure that the refactoring work in #1968 doesn't accidentally introduce any visual bugs. Identical snapshots taken before and after the changes should give reviewers more confidence that no regressions were introduced.