Skip to content
This repository has been archived by the owner on Jan 30, 2020. It is now read-only.

replace call_user_func* with self invoked function #200

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

samsonasik
Copy link
Contributor

as dev-master already use php ^7.1

Copy link
Member

@michalbundyra michalbundyra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@weierophinney weierophinney added this to the 3.0.0 milestone Jun 6, 2018
@weierophinney
Copy link
Member

I rolled back the changes on master that changed the PHP minimum, as we are not supposed to do that in a minor release. 2.10.0 will support 5.6 and 7.0 again.

As such, marking this for 3.0.0.

@weierophinney
Copy link
Member

This repository has been moved to laminas/laminas-mail. If you feel that this patch is still relevant, please re-open against that repository, and reference this issue. To re-open, we suggest the following workflow:

  • Squash all commits in your branch (git rebase -i origin/{branch})
  • Make a note of all changed files (`git diff --name-only origin/{branch}...HEAD
  • Run the laminas/laminas-migration tool on the code.
  • Clone laminas/laminas-mail to another directory.
  • Copy the files from the second bullet point to the clone of laminas/laminas-mail.
  • In your clone of laminas/laminas-mail, commit the files, push to your fork, and open the new PR.
    We will be providing tooling via laminas/laminas-migration soon to help automate the process.

@michalbundyra
Copy link
Member

This repository has been closed and moved to laminas/laminas-mail; a new issue has been opened at laminas/laminas-mail#34.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants