Merge branch 'hotfix/233-parameter-type-hints'

Close #233
zendframework · Jan 29, 2018 · ce839d9 · ce839d9
2 parents 41c3c4e + 331ce27
commit ce839d9
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 3 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -27,6 +27,9 @@ All notable changes to this project will be documented in this file, in reverse
   with default values to their default values if no matching type is found in
   the container.
 
+- [#233](https://github.com/zendframework/zend-servicemanager/pull/233) fixes a
+  number of parameter annotations to reflect the actual types used.
+
 ## 3.3.1 - 2017-11-27
 
 ### Added

diff --git a/src/AbstractFactory/ReflectionBasedAbstractFactory.php b/src/AbstractFactory/ReflectionBasedAbstractFactory.php
@@ -150,7 +150,7 @@ public function canCreate(ContainerInterface $container, $requestedName)
     private function resolveParameterWithoutConfigService(ContainerInterface $container, $requestedName)
     {
         /**
-         * @param ReflectionClass $parameter
+         * @param ReflectionParameter $parameter
          * @return mixed
          * @throws ServiceNotFoundException If type-hinted parameter cannot be
          *   resolved to a service in the container.
@@ -173,7 +173,7 @@ private function resolveParameterWithoutConfigService(ContainerInterface $contai
     private function resolveParameterWithConfigService(ContainerInterface $container, $requestedName)
     {
         /**
-         * @param ReflectionClass $parameter
+         * @param ReflectionParameter $parameter
          * @return mixed
          * @throws ServiceNotFoundException If type-hinted parameter cannot be
          *   resolved to a service in the container.
@@ -189,7 +189,7 @@ private function resolveParameterWithConfigService(ContainerInterface $container
     /**
      * Logic common to all parameter resolution.
      *
-     * @param ReflectionClass $parameter
+     * @param ReflectionParameter $parameter
      * @param ContainerInterface $container
      * @param string $requestedName
      * @return mixed