Skip to content

Commit

Permalink
Planning
Browse files Browse the repository at this point in the history
  • Loading branch information
dumbmatter committed Oct 26, 2024
1 parent 17e34a3 commit c468622
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 4 deletions.
2 changes: 0 additions & 2 deletions TODO
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,6 @@ option to hide jersey numbers on team history page https://discord.com/channels/

separator for inactive years on player profile https://discord.com/channels/290013534023057409/331882115119448065/1294509668000862228

in updateClinchedPlayoffs, calculate with tiebreakers during last few days of the regular season, because that's the only time it really matters, and maybe it's fast enough for that https://discord.com/channels/290013534023057409/290015591216054273/1295887837467512905

Strike out throw out DP does not advance batting order https://discord.com/channels/290013534023057409/290015591216054273/1010153106740351057

support sorting mobile trade tables (like saved trades, trading block)
Expand Down
7 changes: 5 additions & 2 deletions src/worker/core/team/updateClinchedPlayoffs.ts
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,10 @@ const getClinchedPlayoffs = async (

const usePts = g.get("pointsFormula", "current") !== "";

// We can skip tiebreakers because we add an extra 0.1 to the best/worst case win totals. Without skipping tiebreakers, it's way too slow.
const numGames = g.get("numGames", "current");

// We can skip tiebreakers because we add an extra 0.1 to the best/worst case win totals. Without skipping tiebreakers, it's way too slow. You could imagine using tiebreakers only on the last few games of the season... but really it doesn't even work. The bestCases check below isn't actually using the schedule, and it doesn't consider all permutations of game outcomes (which technically would be necessary for all possible tiebreakers) - that would be needed.
// const skipTiebreakers = teamSeasons.every(row => numGames - helpers.getTeamSeasonGp(row) > 3);
const skipTiebreakers = true;

const output: ClinchedPlayoffs[] = [];
Expand All @@ -29,7 +32,7 @@ const getClinchedPlayoffs = async (
const gp = helpers.getTeamSeasonGp(t2);

// Will be wrong if a team is missing a game due to scheduling constraints
const gamesLeft = g.get("numGames", "current") - gp;
const gamesLeft = numGames - gp;

const stats = teamStats.get(t2.tid);

Expand Down

0 comments on commit c468622

Please sign in to comment.