-
Notifications
You must be signed in to change notification settings - Fork 1
Update notebook and fix pyyaml-include
dependency issue
#16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
|
@@ -23,63 +23,63 @@ inputs: | |||||
runs: | ||||||
using: "composite" | ||||||
steps: | ||||||
- name: Check out repository code | ||||||
uses: actions/checkout@v3 | ||||||
with: | ||||||
repository: zenml-io/zenml-project-templates | ||||||
ref: ${{ inputs.ref-template }} | ||||||
path: ./local_checkout | ||||||
- name: Check out repository code | ||||||
uses: actions/checkout@v3 | ||||||
with: | ||||||
repository: zenml-io/zenml-project-templates | ||||||
ref: ${{ inputs.ref-template }} | ||||||
path: ./local_checkout | ||||||
|
||||||
- name: Set up Python | ||||||
uses: actions/setup-python@v4 | ||||||
with: | ||||||
python-version: ${{ inputs.python-version }} | ||||||
|
||||||
- name: Configure git (non-Windows) | ||||||
if: ${{ runner.os != 'Windows' }} | ||||||
shell: bash | ||||||
run: | | ||||||
git config --global user.email "[email protected]" | ||||||
git config --global user.name "ZenML GmbH" | ||||||
|
||||||
- name: Configure git (Windows) | ||||||
if: ${{ runner.os == 'Windows' }} | ||||||
shell: bash | ||||||
run: | | ||||||
"C:\Program Files\Git\bin\git.exe" config --global user.email "[email protected]" | ||||||
"C:\Program Files\Git\bin\git.exe" config --global user.name "ZenML GmbH" | ||||||
- name: Set up Python | ||||||
uses: actions/setup-python@v4 | ||||||
with: | ||||||
python-version: ${{ inputs.python-version }} | ||||||
|
||||||
- name: Install wheel | ||||||
shell: bash | ||||||
run: | | ||||||
pip install wheel | ||||||
|
||||||
- name: Install ZenML | ||||||
if: ${{ inputs.ref-zenml != '' }} | ||||||
shell: bash | ||||||
run: | | ||||||
pip install "git+https://github.com/zenml-io/zenml.git@${{ inputs.ref-zenml }}" "zenml[server]@git+https://github.com/zenml-io/zenml.git@${{ inputs.ref-zenml }}" | ||||||
|
||||||
- name: Install ZenML | ||||||
if: ${{ inputs.ref-zenml == '' }} | ||||||
shell: bash | ||||||
run: | | ||||||
pip install zenml "zenml[server]" | ||||||
|
||||||
- name: Concatenate requirements | ||||||
shell: bash | ||||||
run: | | ||||||
zenml integration export-requirements -o ./local_checkout/integration-requirements.txt sklearn | ||||||
cat ./local_checkout/requirements.txt ./local_checkout/test-requirements.txt ./local_checkout/integration-requirements.txt >> ./local_checkout/all-requirements.txt | ||||||
- name: Configure git (non-Windows) | ||||||
if: ${{ runner.os != 'Windows' }} | ||||||
shell: bash | ||||||
run: | | ||||||
git config --global user.email "[email protected]" | ||||||
git config --global user.name "ZenML GmbH" | ||||||
|
||||||
- name: Install requirements | ||||||
shell: bash | ||||||
run: | | ||||||
pip install -r ./local_checkout/all-requirements.txt | ||||||
- name: Configure git (Windows) | ||||||
if: ${{ runner.os == 'Windows' }} | ||||||
shell: bash | ||||||
run: | | ||||||
"C:\Program Files\Git\bin\git.exe" config --global user.email "[email protected]" | ||||||
"C:\Program Files\Git\bin\git.exe" config --global user.name "ZenML GmbH" | ||||||
|
||||||
- name: Run pytests | ||||||
shell: bash | ||||||
env: | ||||||
ZENML_STACK_NAME: ${{ inputs.stack-name }} | ||||||
run: | | ||||||
pytest ./local_checkout/tests | ||||||
- name: Install wheel | ||||||
shell: bash | ||||||
run: | | ||||||
pip install wheel uv | ||||||
|
||||||
- name: Install ZenML | ||||||
if: ${{ inputs.ref-zenml != '' }} | ||||||
shell: bash | ||||||
run: | | ||||||
uv pip install --system "git+https://github.com/zenml-io/zenml.git@${{ inputs.ref-zenml }}" "zenml[server]@git+https://github.com/zenml-io/zenml.git@${{ inputs.ref-zenml }}" | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Correct the use of - uv pip install --system "git+https://github.com/zenml-io/zenml.git@${{ inputs.ref-zenml }}" "zenml[server]@git+https://github.com/zenml-io/zenml.git@${{ inputs.ref-zenml }}"
+ python -m pip install "git+https://github.com/zenml-io/zenml.git@${{ inputs.ref-zenml }}" "zenml[server]@git+https://github.com/zenml-io/zenml.git@${{ inputs.ref-zenml }}" Committable suggestion
Suggested change
|
||||||
|
||||||
- name: Install ZenML | ||||||
if: ${{ inputs.ref-zenml == '' }} | ||||||
shell: bash | ||||||
run: | | ||||||
uv pip install --system zenml "zenml[server]" | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Correct the use of - uv pip install --system zenml "zenml[server]"
+ python -m pip install zenml "zenml[server]" Committable suggestion
Suggested change
|
||||||
|
||||||
- name: Concatenate requirements | ||||||
shell: bash | ||||||
run: | | ||||||
zenml integration export-requirements -o ./local_checkout/integration-requirements.txt sklearn | ||||||
cat ./local_checkout/requirements.txt ./local_checkout/test-requirements.txt ./local_checkout/integration-requirements.txt >> ./local_checkout/all-requirements.txt | ||||||
|
||||||
- name: Install requirements | ||||||
shell: bash | ||||||
run: | | ||||||
uv pip install --system -r ./local_checkout/all-requirements.txt | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Correct the use of - uv pip install --system -r ./local_checkout/all-requirements.txt
+ python -m pip install -r ./local_checkout/all-requirements.txt Committable suggestion
Suggested change
|
||||||
|
||||||
- name: Run pytests | ||||||
shell: bash | ||||||
env: | ||||||
ZENML_STACK_NAME: ${{ inputs.stack-name }} | ||||||
run: | | ||||||
pytest ./local_checkout/tests |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -3,3 +3,4 @@ copier | |
jinja2-time | ||
zenml[server]>=0.52.0 | ||
notebook | ||
pyyaml-include<2.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Replace
uv
withpython -m
beforepip
commands to ensure correct syntax and standard practice.Committable suggestion