Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make error message nicer for when two artifacts that share a prefix are found #2023

Merged
merged 3 commits into from
Nov 7, 2023
Merged

Make error message nicer for when two artifacts that share a prefix are found #2023

merged 3 commits into from
Nov 7, 2023

Conversation

strickvl
Copy link
Contributor

@strickvl strickvl commented Nov 6, 2023

Addresses this situation:
CleanShot 2023-11-06 at 11 39 28@2x

with nicer error messages.

Pre-requisites

Please ensure you have done the following:

  • I have read the CONTRIBUTING.md document.
  • If my change requires a change to docs, I have updated the documentation accordingly.
  • If I have added an integration, I have updated the integrations table and the corresponding website section.
  • I have added tests to cover my changes.
  • I have based my new branch on develop and the open PR is targeting develop. If your branch wasn't based on develop read Contribution guide on rebasing branch to develop.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Other (add details above)

@strickvl strickvl requested review from fa9r and avishniakov November 6, 2023 10:40
@strickvl strickvl added enhancement New feature or request internal To filter out internal PRs and issues labels Nov 6, 2023
@github-actions github-actions bot added the bug Something isn't working label Nov 6, 2023
fa9r
fa9r suggested changes Nov 6, 2023
View reviewed changes
src/zenml/client.py Outdated Show resolved Hide resolved
@strickvl strickvl requested a review from fa9r November 6, 2023 13:07
fa9r
fa9r approved these changes Nov 6, 2023
View reviewed changes
Copy link
Contributor

@fa9r fa9r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good enough ;)

@strickvl strickvl merged commit 6555c52 into develop Nov 7, 2023
@strickvl strickvl deleted the bugfix/OSS-2558-ugly-error branch November 7, 2023 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@avishniakov avishniakov avishniakov approved these changes

@fa9r fa9r fa9r approved these changes

Assignees
No one assigned
Labels
bug Something isn't working enhancement New feature or request internal To filter out internal PRs and issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@strickvl @fa9r @avishniakov