Instances of the FeatureServices are now used instead of only the names of the FeatureServices.

[aiakide]

Describe changes

I have adapted the get_feature_services function so that it returns instances of the FeaturesService class and not just a list of feature service names. In addition, the functions get_online_features and get_historical_features of the integration can now be used with a list of features / feature views as well as with a FeatureService instance.
This brings the implementation of the feast integration closer to the feast API.

I have also set the minimum version of feast to 0.12.0 to ensure that the necessary Pythom API is available from feast.

This PR closes #3180.

Pre-requisites

Please ensure you have done the following:

• I have read the CONTRIBUTING.md document.
• If my change requires a change to docs, I have updated the documentation accordingly.
• I have added tests to cover my changes.
• I have based my new branch on develop and the open PR is targeting develop. If your branch wasn't based on develop read Contribution guide on rebasing branch to develop.
• If my changes require changes to the dashboard, these changes are communicated/requested.

Types of changes

• [] Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)
• Other (add details above)

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[aiakide]

In addition to the FeatureService, there are other implementations that do not return/use objects, but instead use names. (e.g. zenml.integrations.feast.feature_stores.feast_feature_store.FeastFeatureStore.get_data_sources or zenml.integrations.feast.feature_stores.feast_feature_store.FeastFeatureStore.get_entities). Perhaps this should also be adapted.

[aiakide]

I'm not sure how tests should be written here at zenml. In the case of feast integration, you would have to do quite a bit of mocking.

[strickvl]

LGTM, assuming tests all pass...

[aiakide]

LGTM, assuming tests all pass...

@strickvl When I start the tests locally with the bash script, I get the following error.

RuntimeError: The ZenML database has never been migrated with alembic before. This can happen if you are performing a direct upgrade from a really old version of ZenML. This direct upgrade path is not supported anymore. Please upgrade your ZenML installation first to 0.54.0 or an earlier version and then 
to the latest version.

I don't really understand this error.

Since I have not added any new tests and have not found any tests for the feast integration, everything should probably still work.

[schustmi]

@aiakide This is probably because the tests are trying to run with an already existing, very old database. Which OS are you running on? There should be a zenml-test directory somewhere (I think ~/.config/zenml-test on linux, ~/Library/Application\ Support/zenml-test on MacOS) which contains this DB. If you just delete that directory, it should hopefully run as expected

[aiakide]

@aiakide This is probably because the tests are trying to run with an already existing, very old database. Which OS are you running on? There should be a zenml-test directory somewhere (I think ~/.config/zenml-test on linux, ~/Library/Application\ Support/zenml-test on MacOS) which contains this DB. If you just delete that directory, it should hopefully run as expected

Yes, that helped. Thanks for that :)

[schustmi]

@aiakide Is this ready to merge from your side or are you still making changes?

[aiakide]

@schustmi Yes, I'm done. Can be merged. 🚀