-
Notifications
You must be signed in to change notification settings - Fork 458
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
On-prem Pro tenants: secure enrollment, CSRF tokens and cross-domain authorization flow #3264
base: develop
Are you sure you want to change the base?
Conversation
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
|
2d20c2e
to
33af3ce
Compare
E2E template updates in |
81af11a
to
accbe6f
Compare
E2E template updates in |
…in to allow on-prem deployments
…o/zenml into feature/grow-171-cross-site-auth
external_access_token = request.cookies.get( | ||
config.external_cookie_name | ||
) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TODO: the dependency on the external cookie can be completely removed here ONLY if the dashboard always uses the tenant authorization flow, even for same-site tenants.
Describe changes
This PR packs together several improvements that allow self-hosted zenml servers to be enrolled as ZenML Pro tenants and makes it easier to connect the client to a self-hosted ZenML Pro tenant server and control plane.
Some highlights:
zenml login
,zenml logout
andzenml server list
via a--pro-api-url
argument (e.g.zenml login --pro-api-url https://staging.cloudapi.zenml.io
).Pre-requisites
Please ensure you have done the following:
develop
and the open PR is targetingdevelop
. If your branch wasn't based on develop read Contribution guide on rebasing branch to develop.Types of changes