Create Sagemaker pipeline schedules if specified #3271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
github-actions
bot
added
internal
![hyperlint-ai[bot]](https://avatars.githubusercontent.com/in/718456?s=60&v=4){kind=small}
| @@ -141,7 +141,7 @@ To see a full end-to-end worked example of a custom orchestrator, [see here](htt | |||
|
|
|||
| There are some additional optional features that your orchestrator can implement: | |||
|
|
|||
| * **Running pipelines on a schedule**: if your orchestrator supports running pipelines on a schedule, make sure to handle `deployment.schedule` if it exists. If your orchestrator does not support schedules, you should either log a warning and or even raise an exception in case the user tries to schedule a pipeline. | |||
| * **Running pipelines on a schedule**: if your orchestrator supports running pipelines on a schedule, make sure to handle `deployment.schedule` if it exists. If your orchestrator ules, you should either log a warning and or even raise an exception in case the user tries to schedule a pipeline. | |||
There was a problem hiding this comment.
Suggested change
| * **Running pipelines on a schedule**: if your orchestrator supports running pipelines on a schedule, make sure to handle `deployment.schedule` if it exists. If your orchestrator ules, you should either log a warning and or even raise an exception in case the user tries to schedule a pipeline. | |
| * **Running pipelines on a schedule**: if your orchestrator supports running pipelines on a schedule, make sure to handle `deployment.schedule` if it exists. If your orchestrator rules, you should either log a warning and or even raise an exception in case the user tries to schedule a pipeline. |
Issues:
- Style Guide - (Spelling-error) Did you really mean 'ules'?
Fix Explanation:
The word 'ules' appears to be a typographical error for 'rules'. Correcting this spelling error improves the clarity and accuracy of the documentation.
…zenml into feature/add-sagemaker-schedule
htahir1
commented
Dec 24, 2024
Comment on lines
+798
to
+808
| metadata.update( | ||
| { | ||
| "schedule_rule_name": execution["rule_name"], | ||
| "schedule_type": execution["schedule_type"], | ||
| "schedule_expression": execution["schedule_expr"], | ||
| "pipeline_name": execution["pipeline_name"], | ||
| } | ||
| ) | ||
|
|
||
| if next_execution := execution.get("next_execution"): | ||
| metadata["next_execution_time"] = next_execution.isoformat() |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe changes
Add schedule support for sagemaker. Tested manually.
Pre-requisites
Please ensure you have done the following:
developand the open PR is targetingdevelop. If your branch wasn't based on develop read Contribution guide on rebasing branch to develop.Types of changes