ディレクトリ配下のファイルでもプレビューだけ表示できるように修正 #121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cm-wada-yusuke
commented
Jan 31, 2025
| @@ -225,7 +225,8 @@ | |||
| "@types/webpack-env": "^1.17.0", | |||
| "@typescript-eslint/eslint-plugin": "^5.30.0", | |||
| "@typescript-eslint/parser": "^5.30.0", | |||
| "@vscode/test-web": "^0.0.26", | |||
| "@vscode/test-web": "^0.0.65", | |||
| "@vscode/vsce": "^3.2.2", | |||
There was a problem hiding this comment.
[nits] vsce は非推奨だから @vscode/vsce に変えてねとコンソールに出たため従いました。
cm-wada-yusuke
commented
Jan 31, 2025
| <span className={styles.topic}>{topic}</span> | ||
| <span key={topic} className={styles.topic}> | ||
| {topic} | ||
| </span> |
There was a problem hiding this comment.
[nits] ブラウザコンソールにエラーが出ていたので修正
cm-wada-yusuke
commented
Jan 31, 2025
| article: new RegExp(/\/articles\/(?:[^/]+\/)*[^/]+\.md$/), | ||
| bookChapter: new RegExp(/\/books\/[^/]+\/[^/]+\.md$/), | ||
| bookConfig: new RegExp(`/books/[^/]+/${BOOK_CONFIG_FILE_PATTERN.source}$`), // prettier-ignore | ||
| bookCoverImage: new RegExp(`/books/[^/]+/${BOOK_COVER_IMAGE_FILE_PATTERN.source}$`), // prettier-ignore |
There was a problem hiding this comment.
[note] この部分をプレビューしようとしているファイルの妥当性に使用していました。ここをユーザーフォルダーが入っていても .test() メソッドでパスするような正規表現に修正しています。
| article: new RegExp(/\/articles\/(?:[^/]+\/)*[^/]+\.md$/), | ||
| bookChapter: new RegExp(/\/books\/[^/]+\/[^/]+\.md$/), | ||
| bookConfig: new RegExp(`/books/[^/]+/${BOOK_CONFIG_FILE_PATTERN.source}$`), // prettier-ignore | ||
| bookCoverImage: new RegExp(`/books/[^/]+/${BOOK_COVER_IMAGE_FILE_PATTERN.source}$`), // prettier-ignore |
src/context/app.ts
Outdated
| bookConfig: new RegExp(`^${booksFolderUri}/[^/]+/${BOOK_CONFIG_FILE_PATTERN.source}$`), // prettier-ignore | ||
| bookCoverImage: new RegExp(`^${booksFolderUri}/[^/]+/${BOOK_COVER_IMAGE_FILE_PATTERN.source}$`), // prettier-ignore | ||
| book: new RegExp(/\/books\/[^/]+\/?$/), | ||
| article: new RegExp(/\/articles\/(?:[^/]+\/)*[^/]+\.md$/), |
There was a problem hiding this comment.
[q] ここだけ条件が変わっていると思うのですが意図した変更ですか？（articles以下のディレクトリが深くてもOKになっている？）
There was a problem hiding this comment.
ありがとうございます。意図していませんでした。いろいろ試した結果の正規表現が残ってしまっていました。ご指摘ありがとうございます。ついでに 変数を使っていないところはわざわざ new RegExp() を使う必要もないため、合わせて修正しました。
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📑 Summary
セキュリティ上のリスクについて
により影響は小さいと考えています。
Resolves #120
📋 Tasks
プルリクエストを作成いただく際、お手数ですが以下の内容についてご確認をお願いします。
canaryブランチに対するプルリクエストであるより詳しい内容は Pull Request Policy を参照してください。