fix: allow duplicate slice names #532
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @zaidsheikh is this ready for review? |
|
I need to push one more commit to fix an issue with charts (they currently assume slice names are unique, so only one slice is shown even if multiple slices with the same name are selected). |
|
Ah ok sounds good, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Allow duplicate slice names, mainly so we can easily "Create slices for all values" without worrying about existing slice names. This was decided during a discussion on ZEN-282.
(Note: we probably need a way to disambiguate slices with the same name in the chart editor … maybe by including the folder name as well)
References
fix ZEN-399
(Note: this is a duplicate of my previous PR #531 which was created from a fork. CI tests kept failing because Github Action secrets are not accessible if the PR is from a fork)