-
-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: incorrect calculation of backlink field for self-relations #1540
Conversation
WalkthroughWalkthroughThe changes ensure that fields in the data model do not become self-referential during processing by adding a condition to skip processing when Changes
Sequence Diagram(s)N/A Assessment against linked issues
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Outside diff range and nitpick comments (2)
packages/sdk/src/model-meta-generator.ts (2)
Line range hint
331-331
: ReplaceisNaN
withNumber.isNaN
.The current use of
isNaN
is flagged as unsafe because it performs type coercion. UsingNumber.isNaN
provides a safer alternative as it does not coerce types.- if (isNaN(v)) { + if (Number.isNaN(v)) {Also applies to: 334-334
Line range hint
364-366
: Remove unnecessary else clause.The
else
clause after early return statements is unnecessary and can be removed to simplify the code.- } else { - return undefined; - }
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (2)
- packages/sdk/src/model-meta-generator.ts (1 hunks)
- tests/regression/tests/issue-1530.test.ts (1 hunks)
Additional context used
Biome
packages/sdk/src/model-meta-generator.ts
[error] 364-366: This else clause can be omitted because previous branches break early.
Unsafe fix: Omit the else clause.
(lint/style/noUselessElse)
[error] 331-331: isNaN is unsafe. It attempts a type coercion. Use Number.isNaN instead.
See the MDN documentation for more details.
Unsafe fix: Use Number.isNaN instead.(lint/suspicious/noGlobalIsNan)
[error] 334-334: isNaN is unsafe. It attempts a type coercion. Use Number.isNaN instead.
See the MDN documentation for more details.
Unsafe fix: Use Number.isNaN instead.(lint/suspicious/noGlobalIsNan)
Additional comments not posted (2)
tests/regression/tests/issue-1530.test.ts (1)
1-36
: Comprehensive test suite for issue 1530.This test suite effectively covers the scenario described in the PR, from loading the schema to performing the update operations and verifying the results. The use of
enhance
andprisma
seems appropriate for the operations needed.packages/sdk/src/model-meta-generator.ts (1)
298-301
: Correct handling of self-referential fields.The addition of a check to skip self-referential fields is a direct and effective solution to the issue described. This prevents erroneous backlink calculations that could lead to runtime errors.
Fixes #1530