Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: unwrap LazyCommand #27

Merged
merged 2 commits into from
Jan 8, 2025
Merged

fix: unwrap LazyCommand #27

merged 2 commits into from
Jan 8, 2025

Conversation

kbond
Copy link
Member

@kbond kbond commented Jan 8, 2025

Continuation of #24 (as I couldn't push to @Cryde's branch).

When Symfony registers your command as "lazy", it wraps it in a LazyCommand. When using InteractsWithConsole::consoleCommand(MyCommand:class) it doesn't find it because it's actually a LazyCommand instance. This PR fixes it by unwrapping lazy commands.

@kbond kbond changed the title fix: unwrap LazyCommands fix: unwrap LazyCommand Jan 8, 2025
@kbond kbond merged commit 44b4af3 into zenstruck:1.x Jan 8, 2025
22 checks passed
@kbond kbond deleted the lazy-command-fix branch January 8, 2025 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant