feat: validate objects #801
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikophil
commented
Feb 2, 2025
| break; | ||
| } | ||
| } | ||
| $application = new Application(new TestKernel($_ENV['APP_ENV'], true)); |
There was a problem hiding this comment.
this is easier for debugging
nikophil
commented
Feb 2, 2025
|
|
||
| ->set('.zenstruck_foundry.validation_listener', ValidationListener::class) | ||
| ->args([service('validator')]) | ||
| ->tag('kernel.event_listener', ['event' => AfterInstantiate::class, 'method' => '__invoke']) |
There was a problem hiding this comment.
I was wondering if I should listen AfterPersist event, and trigger validation on this event for persisting factories, but it feels wrong to validate after persisting
nikophil
commented
Feb 2, 2025
| $violations = $this->validator->validate($event->object); | ||
|
|
||
| if ($violations->count() > 0) { | ||
| throw new ValidationFailedException($event->object, $violations); |
There was a problem hiding this comment.
I'm wondering if we should throw this exception or another one from Foundry's namespace. This ones is kinda ugly:
Symfony\Component\Validator\Exception\ValidationFailedException: Object(Zenstruck\Foundry\Tests\Fixture\Entity\EntityForValidation).name:
This value should not be blank. (code c1051bb4-d103-4f74-8988-acbcafc7fdc3)
nikophil
commented
Feb 2, 2025
Comment on lines
+92
to
+94
| ->arrayNode('validation') | ||
| ->info('Automatically validate the objects created.') | ||
| ->canBeEnabled() |
There was a problem hiding this comment.
it seems logical to add this config under instantiator conf, but this could be moved outisde from it.
COil
reviewed
Feb 2, 2025
| { | ||
| public function __construct( | ||
| #[ORM\Column()] | ||
| #[Assert\NotBlank()] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Credits to @COil for the idea https://www.strangebuzz.com/en/blog/validating-your-data-fixtures-with-the-alice-symfony-bundle 😄