perf: revert validation / #[AsFoundryHook] / global event system
#871
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikophil
changed the title
#[AsFoundryHook] / global event system
|
Does it happen when debug=0 ? I had problems previously with traceable event dispatcher and the profiler |
|
nikophil
added a commit
to nikophil/foundry
that referenced
this pull request
Apr 14, 2025
…ystem (zenstruck#871)" This reverts commit 12b4419.
nikophil
added a commit
to nikophil/foundry
that referenced
this pull request
Apr 14, 2025
…ystem (zenstruck#871)" This reverts commit 12b4419.
|
I did try that yes, and but it wasn't enough |
Closed
|
We had massive problems with events & TwgComponent (and still have some problems with Live) .. i'll check my notes to see if some of the causes apply here. |
nikophil
added a commit
to nikophil/foundry
that referenced
this pull request
Apr 28, 2025
…ystem (zenstruck#871)" This reverts commit 12b4419.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because of huge performance problems, I roll back those PRs:
#[AsFoundryHook]#802Maybe we'll reintroduce it in the future if we find a way that do not create performance problems