feat(2.10): dispatch events #974
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikophil
force-pushed
the
feat/re-enable-global-events
branch
3 times, most recently
from
3004add to
03d8fe3
Compare
nikophil
force-pushed
the
feat/re-enable-global-events
branch
3 times, most recently
from
f9d6ae7 to
ad03043
Compare
nikophil
force-pushed
the
feat/re-enable-global-events
branch
3 times, most recently
from
4426dc0 to
c6a0ac4
Compare
nikophil
force-pushed
the
feat/re-enable-global-events
branch
from
c6a0ac4 to
c21a69d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this was previously validated here
I'm still trying to play with this to tackle perf problem 😅
EDIT: Apparently, the solution for perf problem was to disable the flush call after
postPersist()(see first commit)