feat: show handler name for failures (#111)

zenstruck · Nov 13, 2024 · 5a9cf9e · 5a9cf9e
1 parent ac04193
commit 5a9cf9e
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 5 deletions.
diff --git a/src/History/HistoryListener.php b/src/History/HistoryListener.php
@@ -146,8 +146,9 @@ private function createResults(Envelope $envelope, ?HandlerFailedException $exce
             return new Results($results);
         }
 
-        foreach ($exception->getWrappedExceptions() as $nested) {
+        foreach ($exception->getWrappedExceptions() as $handler => $nested) {
             $results[] = [
+                'handler' => $handler,
                 'exception' => $nested::class,
                 'message' => $nested->getMessage(),
                 'data' => $this->normalizer->normalize($nested),

diff --git a/src/History/Model/Result.php b/src/History/Model/Result.php
@@ -41,7 +41,7 @@ public function isFailure(): bool
 
     public function handler(): ?Type
     {
-        if (!isset($this->data['handler'])) {
+        if (!isset($this->data['handler']) || !\is_string($this->data['handler'])) {
             return null;
         }
 

diff --git a/templates/detail.html.twig b/templates/detail.html.twig
@@ -130,17 +130,21 @@
                     <div class="card-header">
                         {% if result.isFailure %}
                             <svg fill="currentcolor" height="1em" width="1em" class="me-1 align-text-bottom text-danger" role="img" aria-label="Error:"><use xlink:href="#exclamation-triangle-fill"/></svg>
-                            <abbr title="{{ result.failure }}"><code>{{ result.failure.shortName }}</code></abbr>
                         {% else %}
                             <svg fill="currentcolor" height="1em" width="1em" class="me-1 align-text-bottom text-success" role="img" aria-label="Success:"><use xlink:href="#check-circle-fill"/></svg>
+                        {% endif %}
+                        {% set handler = result.handler|default %}
+                        {% if handler %}
                             <code>
-                                <abbr title="{{ result.handler }}">{{ result.handler.shortName }}</abbr>{% if result.handler.description %}::{{ result.handler.description }}(){% endif %}
+                                <abbr title="{{ handler }}">{{ handler.shortName }}</abbr>{% if handler.description %}::{{ handler.description }}(){% endif %}
                             </code>
-                            Results
+                        {% else %}
+                            <small class="text-secondary"><em>Unknown Handler</em></small>
                         {% endif %}
                     </div>
                     {% if result.isFailure %}
                         <div class="alert card-alert alert-danger mb-0">
+                            <abbr title="{{ result.failure }}"><code>{{ result.failure.shortName }}</code></abbr>:
                             {{ result.failure.description }}
                         </div>
                     {% endif %}