[RFC] feat: allow retrying failed messages #103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kbond
force-pushed
the
ui/retry-failed
branch
from
a34c0c1 to
187b6b0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #15.
(Depends on #102)
Adds a button to retry a failed message. I chose not to use the failure transport to retry as I didn't want to block the request. So I send it back to the original transport allowing it to be retried asynchronously. This does trigger the original retries again on another failure whereas
bin/console messenger:failed:retrytries again just once and drops. When the retries are used up it is not sent back to the failure transport a second time.I'm not 100% certain this is without edge-cases I'm not seeing so if anyone has any feedback, I'd appreciate it!