Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: normalize_process_exception() test #91

Closed
wants to merge 2 commits into from

Conversation

Chris53897
Copy link
Contributor

@Chris53897 Chris53897 commented Jul 9, 2024

i am not sure why $result['error_output'] is emtpy now in the ci runs, and was not before.
Changes in symfony?

Copy link
Member

@kbond kbond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It only fails in the code coverage job? That seems weird...

tests/History/ResultNormalizerTest.php Outdated Show resolved Hide resolved
@Chris53897
Copy link
Contributor Author

It fails on different runs. I see some action runs, that is was on code coverage. But there are others if i remember correct.

I will try to find some time, to have a deeper look.

Now it is NULL instead of '' ?

1) Zenstruck\Messenger\Monitor\Tests\History\ResultNormalizerTest::normalize_process_exception
Failed asserting that null is identical to 127.

@kbond
Copy link
Member

kbond commented Oct 28, 2024

I've hopefully made this test less brittle in #101

@kbond kbond closed this Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants