-
-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: add notes about CSRF and Form requirements #98
Conversation
You're totally right. Out of curiosity, does |
@kbond nope, Also while debugging, I discovered that there is also used the CSRF token from symfony/form |
We're kind of in a tough spot here. The csrf & form is only required when using the UI. This package can still be used without so I don't want to make these hard deps. I think, for now, just adding notes to the doc would be best. In the future, the best way would be to break this package up into backend and frontend packages.
|
Got it. Didn't remove the CSRF check and added the suggestion to install symfony/form. Also added the dependency in or project even if it's an API :/ Still removed the humanize from the schedule name, so that it's easier understandable which schedule it is. Can revert it if needed. |
After some more testing, I see there are more changes required to support CSRF.
Should I add it to the Readme too? I would rewrite the note to: Note If using symfony/scheduler, you'll need |
@SpartakusMd, sorry for the delay here. So if not using scheduler, csrf is not required? Maybe let's have two notes then: Note
Note If using |
Thanks for your patience @SpartakusMd! |
humanize
twig filter is used to display a human readable scheduler names. The filter usesFormRenderer
which is available insymfony/form
. Should the bundle drop the use of humanize? It seems too small benefit to add such a big dependency, especially for API or console projects.Error: