Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove CMSIS #256

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

mmahadevan108
Copy link
Collaborator

Zephyr project uses the cmsis module, no need for CMSIS inside mcux-sdk

Delete references to CMSIS from cmake files

Signed-off-by: Mahesh Mahadevan <[email protected]>
Delete references to CMSIS from cmake files

Signed-off-by: Mahesh Mahadevan <[email protected]>
Use the cmsis module provided by Zephyr

Signed-off-by: Mahesh Mahadevan <[email protected]>
Zephyr uses the cmsis module

Signed-off-by: Mahesh Mahadevan <[email protected]>
@mmahadevan108
Copy link
Collaborator Author

cc @manuargue @JiafeiPan @dbaluta @iuliana-prodan

@JiafeiPan
Copy link
Contributor

JiafeiPan commented Jul 13, 2023

I don't think we can remove nxp_hal's CMSIS, as there are some Cortex-A Core ARM64 supoort in it, currently ARM64 is not supported in Zephyr's CMSIS module, so NXP hal's CMSIS can't be replaced by Zephyr's CMSIS module.

@dbaluta
Copy link
Contributor

dbaluta commented Jul 13, 2023

I don't think we can remove nxp_hal's CMSIS, as there are some Cortex-A Core ARM64 supoort in it, currently ARM64 is not supported in Zephyr's CMSIS module, so NXP hal's CMSIS can't be replaced by Zephyr's CMSIS module.

Then we should push Cortex-A ARM64 support into Zephyr CMSIS. Duplicating things all around is not really easy to maintain.

@LaurentiuM1234
Copy link
Contributor

Gave this PR a shot and, as it is, it breaks all of the imx93-related builds from Zephyr. BTW, why keep the core_x.h includes from the device files if you removed them? Doesn't seem right. (e.g: in MIMX9352_ca55.h you still include core_ca55.h which doesn't exist anymore?)

@mmahadevan108
Copy link
Collaborator Author

MIMX9

I think this is related to the work added by @JiafeiPan in the CMSIS folder. I am working with him on the best way to include this file in the Zephyr project.

@JiafeiPan
Copy link
Contributor

I will upstream AARCH64 patches to CMSIS community, before we will integrate them into Zephyr's CMSIS, please don't remove hal_nxp's CMSIS, thanks.

@dleach02
Copy link
Member

I will upstream AARCH64 patches to CMSIS community, before we will integrate them into Zephyr's CMSIS, please don't remove hal_nxp's CMSIS, thanks.

@JiafeiPan what is the status of this?

@JiafeiPan
Copy link
Contributor

I will upstream AARCH64 patches to CMSIS community, before we will integrate them into Zephyr's CMSIS, please don't remove hal_nxp's CMSIS, thanks.

@JiafeiPan what is the status of this?

Hi, @dleach02 , I created a PR target for community, but as CMSIS latest software architecture is changed, so it will need so much effort to adapt to latest CMSIS code base, I don't think it can be merged in a short time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants