-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mcux: add support for imxrt1176 rtwdog #449
base: master
Are you sure you want to change the base?
mcux: add support for imxrt1176 rtwdog #449
Conversation
Signed-off-by: Daniel Berhe <[email protected]>
@@ -225,6 +225,7 @@ include_driver_ifdef(CONFIG_PWM_MCUX pwm driver_pwm) | |||
include_driver_ifdef(CONFIG_VIDEO_MCUX_CSI csi driver_csi) | |||
include_driver_ifdef(CONFIG_VIDEO_MCUX_MIPI_CSI2RX mipi_csi2rx driver_mipi_csi2rx) | |||
include_driver_ifdef(CONFIG_WDT_MCUX_IMX_WDOG wdog01 driver_wdog01) | |||
include_driver_ifdef(CONFIG_WDT_MCUX_IMX_RTWDOG rtwdog driver_rtwdog) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you align indentation here?
Typically the sequence we follow is to submit the Zephyr side PR referencing the HAL module update- then once the Zephyr side PR is passing CI and has been reviewed (IE nearly ready to merge), we update the HAL module, and then the contributor will perform one final update to the Zephyr side to pull in the latest revision of the HAL main branch. At that point the Zephyr side PR can merge. For this case, I'd submit the RTWDOG driver to Zephyr, and reference this PR for the NXP HAL module revision in that PR. For more details, take a look at the module update procedure: https://docs.zephyrproject.org/latest/develop/modules.html#process-for-submitting-changes-to-existing-modules. This PR is in progress, and has an example of the update process: https://github.com/zephyrproject-rtos/zephyr/pull/79376/files#diff-d7f4082837dc3cb270fcf1abd68188216fdadee294e01611b8ca59ddea7fdbb3 |
@danielb-tkjcy3rq we need a Zephyr side manifest PR |
@danielb-tkjcy3rq , any update on the Zephyr side PR for this change to the HAL. |
Sorry not yet. Things have been and are a bit manic at work. I will try to get back to this next week. |
This is in preparation for adding a Zephyr watchdog driver for wdog3 and wdog4 found on the imxrt1170 MCUs.