Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drivers: wifi: nxp:Fix the compilation error on the MIMXRT1170_EVK board with the NXP_88W8987_MURATA_1ZM_M2 WiFi module #473

Closed
wants to merge 0 commits into from

Conversation

CsBoBoNice
Copy link

  • Fix the compilation error on the MIMXRT1170_EVK board with the NXP_88W8987_MURATA_1ZM_M2 WiFi module
  • Support configuring Wi-Fi threads stack size

@CsBoBoNice
Copy link
Author

This code needs to be used with the following pull request:

zephyrproject-rtos/zephyr#81694

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a binary blob. We cannot include this directly. Take a look here to see how we download these for other modules: https://github.com/zephyrproject-rtos/hal_nxp/blob/master/zephyr/module.yml#L19

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be more clear here- we are allowed to simply download the binary blob into this directory- I assume you are pulling the blobs from here: https://github.com/NXP/wifi_nxp/tree/mcux_wifi_release/wifi_bt_firmware?

We will need to get approval from the TSC to add these blobs though (ping @dleach02), and may need to discuss internally at NXP how best to host these binaries.

WIFI_BT_TX_PWR_LIMITS="wlan_txpwrlimit_cfg_murata_1ZM_WW.h"
CONFIG_NXP_WIFI_ED_OFFSET_2G=0x06
CONFIG_NXP_WIFI_ED_OFFSET_5G=0x06
WIFI_BT_USE_M2_INTERFACE
)

zephyr_compile_definitions_ifdef(CONFIG_IW416_AW_AM457_USD
if(CONFIG_NXP_88W8987)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This approach makes sense, but we should expand it out to manage other modules (for example the IW416)

@MaochenWang1
Copy link
Collaborator

Hi @CsBoBoNice please solve the conflict

@CsBoBoNice
Copy link
Author

Apologies for the inconvenience caused. Due to an unintended action on my part, I am unable to reopen the original PR. As a result, I have had to create a new PR to address the changes. Please find the new PRs at the following links:

I appreciate your understanding and look forward to your feedback on these new PRs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants