-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
zephyr: module.yml: Add missing module name #227
Conversation
@jhedberg FYI. Thanks for the heads up. |
@erwango btw, this changes the command used for fetching blobs from |
Valuable information indeed. Thanks, I'll check this. |
affc79f
to
8deb9f6
Compare
PR updated to keep the ability to keep the existing command |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@erwango btw, this changes the command used for fetching blobs from
west blobs fetch stm32
towest blobs fetch hal_stm32
, so if you have any documentation with such references it may need to be updated.PR updated to keep the ability to keep the existing command
west blobs fetch stm32
functional.
@erwango the reason I pointed out the difference was just to update documentation. I still think that hal_stm32
is the correct name, since then it's consistent with how all other Zephyr HAL modules are defined and then it's also equal to the module name as it is defined in west.yml
:
If you just call it stm32
it's equally (if not more) likely that people will be confused when they are not able to fetch blobs the same way as they do for other modules. Furthermore, the name hal_stm32
would be consistent with how the various CMake and Kconfig variables are defined (I suspect those get created based on west.yml
).
This used to be an even bigger problem before: zephyrproject-rtos/zephyr#73901, however even now I think it's important to be consistent and predictable between modules. We used to have the same bug in hal_silabs
, but fixed it with zephyrproject-rtos/hal_silabs@a09dd1b
@jhedberg I was just wanting to avoid impacting users for vain reason, but since you gave me valid ones, I'll do the change to |
Field `name` is missing in module.yml file. Fix this, using the canonical name as used by other hals. Signed-off-by: Erwan Gouriou <[email protected]>
8deb9f6
to
f0aab9f
Compare
Field
name
is missing in module.yml file.Fix this.