nrf_wifi: Add support to read battery voltage #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imapa
requested review from
rajb9,
krish2718,
sachinthegreen,
rado17 and
jukkar
as code owners
rajb9
approved these changes
Dec 2, 2024
krish2718
reviewed
Dec 2, 2024
krish2718
reviewed
Dec 2, 2024
krish2718
reviewed
Dec 2, 2024
krish2718
reviewed
Dec 2, 2024
imapa
force-pushed
the
vbat
branch
2 times, most recently
from
b0719eb to
cf688ec
Compare
rajb9
approved these changes
Dec 3, 2024
This commit introduces support for reading and displaying the battery voltage. Signed-off-by: Mahammadyunus Patil <[email protected]>
krish2718
approved these changes
Dec 3, 2024
krish2718
approved these changes
Dec 3, 2024
jukkar
approved these changes
Dec 7, 2024
|
Can you please add a copyright to |
sachinthegreen
requested changes
Jan 10, 2025
| if (bat_volt_params.cmd_status) { | ||
| nrf_wifi_osal_log_err("Volatge reading failed"); | ||
| } | ||
| else { |
There was a problem hiding this comment.
This should be on the previous line (i.e } else { ) ?
| struct nrf_wifi_bat_volt_params get_bat_volt; | ||
| struct nrf_wifi_fmac_dev_ctx_rt* rt_dev_ctx = NULL; | ||
| unsigned int count = 0; | ||
| rt_dev_ctx = wifi_dev_priv(fmac_dev_ctx); |
There was a problem hiding this comment.
Insert blank line before this.
| else { | ||
| bat_volt = (BAT_CONST_1 + (BAT_CONST_2 * bat_volt_params.voltage)); | ||
|
|
||
| nrf_wifi_osal_log_info("The battery voltage is = %d mV", |
There was a problem hiding this comment.
API says Retrieves the battery voltage in volts but value here seems to be in mV ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit introduces support for reading and
displaying the battery voltage.