kconfig: Signal newlib support in Kconfig too #626
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This lets Kconfig stanzas detect newlib support in the toolchain Signed-off-by: Keith Packard <[email protected]>
galak
requested changes
Feb 9, 2023
| @@ -7,3 +7,9 @@ config TOOLCHAIN_ZEPHYR_0_16 | |||
| config TOOLCHAIN_ZEPHYR_SUPPORTS_THREAD_LOCAL_STORAGE | |||
| def_bool y | |||
| select TOOLCHAIN_SUPPORTS_THREAD_LOCAL_STORAGE | |||
|
|
|||
| config NEWLIB_SUPPORTED | |||
There was a problem hiding this comment.
I don't think a generic option should be in here. For example how will the arm-gnu-embedded toolchain enable NEWLIB_SUPPORTED. This should be in Zephyr proper and have something like:
config TOOLCHAIN_ZEPHYR_SUPPORTS_NEWLIB`
def_bool y
select NEWLIB_SUPPORTED
There was a problem hiding this comment.
or add select NEWLIB_SUPPORTED under config TOOLCHAIN_ZEPHYR_0_16
There was a problem hiding this comment.
I've already got a proposed patch which does that (no need for the version check, Zephyr SDK has always supported newlib). I was just following the suggestion about where similar mechanism for Picolibc should live, and that will live in sdk-ng. Happy to have it in Zephyr instead; it's a lot easier to manage there anyways.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This lets Kconfig stanzas detect newlib support in the toolchain
Working on zephyr PR zephyrproject-rtos/zephyr#54637
Signed-off-by: Keith Packard [email protected]