-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
microblaze: pull in gcc/bintuils/gdb patches from meta-xilinx #647
base: main
Are you sure you want to change the base?
Conversation
I think the whole series of pending microblaze fixes should be added here, not just one of them. |
Sorry, I've been busy with work. I'll make use of the holidays now and start applying. I have some catching up to do... |
fcf0562
to
872e6eb
Compare
872e6eb
to
cdc8748
Compare
Tried to apply all patches I could find in binutils as the 1st step. Came across various conflicts. Tried to solve them naively but it seems I failed. |
cdc8748
to
464c189
Compare
I'll be damned. Binutils patches applied cleanly with 464c189 |
bdae8d7
to
8113984
Compare
1c22c25
to
876f6fc
Compare
GCC and binutils patches applied successfully but GDB patches are problematic. I'm working on it. |
4fc35b2
to
cac164f
Compare
9cdbb75
to
091c9ee
Compare
CI building for the last time. I will confirm microblaze toolchain still passes all tests (Zephyr & picolibc) and mark this as "Ready for review". I expect no issues. |
@alpsayin Hi. I have merged the GCC patch and left some reviews on the rest of the PRs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Leaving a -1 until all the relevant toolchain patches are merged and this PR is updated to reference the merged commits.
Seen it, on it. Thank you! |
170e540
to
94298da
Compare
94298da
to
749454f
Compare
5460835
to
563a6be
Compare
563a6be
to
ebf7ecd
Compare
b24d363
to
214f390
Compare
Note to self: microblaze-qemu might be out of date, I'll need to figure out what's going on with that. |
New issue found, potential fix under test zephyrproject-rtos/gcc#37 |
81825cc
to
645ae98
Compare
This patchset fixes many known issues on gnu-toolchain for microblaze. But mainly the atomic-cas and binutils incorrect relocation issues. Patches obtained from https://github.com/xilinx/meta-xilinx/ Signed-off-by: Alp Sayin <[email protected]>
645ae98
to
b944af6
Compare
This commit pulls in the fix for the Microblaze gcc atomic compare-and-swap issue where atomic cas returns the inverse Boolean value of what it should. zephyrproject-rtos/gcc#21These patchsets fixes many known issues on gnu-toolchain for microblaze.
But mainly the atomic-cas and binutils incorrect relocation issues.
Patches obtained from https://github.com/xilinx/meta-xilinx/ repository,
Fixes
raise
is overwriting the signal handler with SIGDFL picolibc/picolibc#460I've given up and disabled microblaze64 toolchain build. meta-xilinx patches somehow manage to break the same toolchain that they introduced. I have no intention to support microblaze64 yet and this saves a few CI cycles.
Finally; if/when AMD/Xilinx software group manages to upstream these to gnu-gcc, the squashed commits in individual repositories should provide an easy transition (revert and rebase) when it's time to upgrade zephyr-gcc.
CC @keith-packard